Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename frontend-app-program-manager to frontend-app-program-console #27

Merged
merged 2 commits into from Mar 25, 2020

Conversation

how015
Copy link
Contributor

@how015 how015 commented Mar 22, 2020

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One simple suggestion.

@@ -1,4 +1,4 @@
# frontend-app-program-manager
# frontend-app-program-console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested new description (as the current one also seems to be misleading, just like program-manager was):
A micro-frontend for administering edX program membership through the Registrar API.

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #27 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   39.65%   39.65%           
=======================================
  Files          29       29           
  Lines         348      348           
  Branches       41       41           
=======================================
  Hits          138      138           
  Misses        190      190           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40dce9e...c7e4390. Read the comment docs.

@how015 how015 merged commit 2d2210a into master Mar 25, 2020
@how015 how015 deleted the rename-repo branch March 25, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants