feat: add user email and name in user dropdown menu #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
3 times, most recently
from
fca4ef8
to
dadee8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 51 52 +1
Lines 813 813
Branches 163 158 -5
=======================================
Hits 588 588
Misses 215 215
Partials 10 10 ☔ View full report in Codecov by Sentry. |
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
3 times, most recently
from
2e55de9
to
4202bcc
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
2 times, most recently
from
12ffa7c
to
a32a5ff
Compare
syedsajjadkazmii
previously approved these changes
Mar 1, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
from
31a5bd6
to
0845a84
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
2 times, most recently
from
a2258c9
to
c403993
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
from
c403993
to
dfb1acb
Compare
syedsajjadkazmii
approved these changes
Mar 6, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
2 times, most recently
from
59b333f
to
2869cfc
Compare
syedsajjadkazmii
approved these changes
Mar 12, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
from
2869cfc
to
8f92dca
Compare
BilalQamar95
approved these changes
Mar 12, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
2 times, most recently
from
3a746dd
to
82783e2
Compare
zainab-amir
reviewed
Mar 12, 2024
src/Header.messages.jsx
Outdated
| @@ -78,7 +78,7 @@ const messages = defineMessages({ | |||
| }, | |||
| 'header.label.account.menu.for': { | |||
| id: 'header.label.account.menu.for', | |||
| defaultMessage: 'Account menu for {username}', | |||
| defaultMessage: 'Account menu for {name}', | |||
| description: 'The aria label for the account menu trigger when the username is displayed in it', | |||
There was a problem hiding this comment.
Suggested change
| description: 'The aria label for the account menu trigger when the username is displayed in it', | |
| description: 'The aria label for the account menu trigger', |
| @@ -37,7 +37,7 @@ exports[`<Header /> minimal renders correctly for authenticated users when minim | |||
| alt="" | |||
| aria-expanded={false} | |||
| aria-haspopup={true} | |||
| aria-label="Account menu for edX" | |||
| aria-label="Account menu for " | |||
There was a problem hiding this comment.
Why is the name missing in the aria-label? Probably the test needs to be fixed.
| @@ -293,7 +291,7 @@ exports[`<Header /> renders correctly for authenticated users on mobile 1`] = ` | |||
| type="button" | |||
| > | |||
| <img | |||
| alt="edX" | |||
| alt={null} | |||
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
2 times, most recently
from
3964710
to
38b2148
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
3 times, most recently
from
74798c0
to
372ba7a
Compare
mubbsharanwar
changed the title
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
2 times, most recently
from
e75bac6
to
5b1d37c
Compare
We added 
|
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
from
5b1d37c
to
c9e0c80
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
from
c9e0c80
to
5edec7b
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
3 times, most recently
from
a379834
to
b966f33
Compare
BilalQamar95
approved these changes
Mar 20, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1851
branch
from
b966f33
to
be9c582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the username from the registration form that's why we are removing the username from the user-facing views and adding the user email and full name in the user menu dropdown.
Screenshort
VAN-1851