fix: adds optional params for when process.env isn't configured

openedx · Aug 11, 2020 · 832fcf1 · 832fcf1
1 parent 85e9316
commit 832fcf1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/src/learnerPortalLinks.js b/src/learnerPortalLinks.js
@@ -16,13 +16,17 @@ function cacheLinks(userId, links) {
   );
 }
 
-async function fetchLearnerPortalLinks(apiClient, userId) {
+async function fetchLearnerPortalLinks(
+  apiClient,
+  userId,
+  learnerPortalHostname = process.env.ENTERPRISE_LEARNER_PORTAL_HOSTNAME,
+  lmsBaseUrl = process.env.LMS_BASE_URL,
+) {
   const learnerPortalLinks = [];
-  const learnerPortalHostname = process.env.ENTERPRISE_LEARNER_PORTAL_HOSTNAME;
   if (!learnerPortalHostname) {
     return learnerPortalLinks;
   }
-  const response = await fetchEnterpriseCustomers(apiClient);
+  const response = await fetchEnterpriseCustomers(apiClient, lmsBaseUrl);
   const enterpriseCustomers = response.data.results;
   try {
     for (let i = 0; i < enterpriseCustomers.length; i += 1) {
@@ -72,7 +76,12 @@ function getCachedLearnerPortalLinks(userId) {
   return null;
 }
 
-export default async function getLearnerPortalLinks(apiClient, authenticatedUser) {
+export default async function getLearnerPortalLinks(
+  apiClient,
+  authenticatedUser,
+  learnerPortalHostname = process.env.ENTERPRISE_LEARNER_PORTAL_HOSTNAME,
+  lmsBaseUrl = process.env.LMS_BASE_URL,
+) {
   let learnerPortalLinks = [];
 
   if (authenticatedUser !== null && isEnterpriseUser(authenticatedUser)) {
@@ -82,7 +91,12 @@ export default async function getLearnerPortalLinks(apiClient, authenticatedUser
     if (cachedLinks != null) {
       learnerPortalLinks = learnerPortalLinks.concat(cachedLinks);
     } else {
-      const links = await fetchLearnerPortalLinks(apiClient, userId);
+      const links = await fetchLearnerPortalLinks(
+        apiClient,
+        userId,
+        learnerPortalHostname,
+        lmsBaseUrl,
+      );
       learnerPortalLinks = learnerPortalLinks.concat(links);
     }
   }

diff --git a/src/service.js b/src/service.js
@@ -1,4 +1,4 @@
-const fetchEnterpriseCustomers = apiClient => apiClient.get(`${process.env.LMS_BASE_URL}/enterprise/api/v1/enterprise-customer/`);
+const fetchEnterpriseCustomers = (apiClient, lmsBaseUrl = process.env.LMS_BASE_URL) => apiClient.get(`${lmsBaseUrl}/enterprise/api/v1/enterprise-customer/`);
 
 // eslint-disable-next-line import/prefer-default-export
 export { fetchEnterpriseCustomers };