feat: add hotjar package #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long74100
force-pushed
the
add-hot-jars-lib
branch
4 times, most recently
from
90cc131
to
78347fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 75.99% 77.37% +1.38%
==========================================
Files 33 34 +1
Lines 604 641 +37
Branches 152 160 +8
==========================================
+ Hits 459 496 +37
Misses 132 132
Partials 13 13
Continue to review full report at Codecov.
|
long74100
force-pushed
the
add-hot-jars-lib
branch
from
78347fc
to
1dcd2d3
Compare
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "clean": "npm run clean --workspaces && rm -rf ./node_modules", | |||
| "build": "npm run build --workspaces", | |||
| "test": "npm run test --workspaces", | |||
| "test:watch": "npm run test -- --watch", | |||
There was a problem hiding this comment.
Should this command be npm run test:watch --workspaces to run test:watch in each package in the workspace?
packages/hotjar/README.rst
Outdated
| .. |Build Status| image:: https://github.com/edx/frontend-enterprise/actions/workflows/release.yml/badge.svg | ||
| :target: https://github.com/edx/frontend-enterprise/actions | ||
| .. |npm_version| image:: https://img.shields.io/npm/v/@edx/frontend-enterprise-utils.svg | ||
| :target: @edx/frontend-enterprise-utils |
There was a problem hiding this comment.
nit: @edx/frontend-enterprise-utils -> @edx/frontend-enterprise-hotjar throughout this file
| @@ -0,0 +1,88 @@ | |||
| /* eslint-disable no-console */ | |||
|
|
|||
There was a problem hiding this comment.
It might be a good idea to drop a link to Github where we sourced/adapted this from for future reference.
adamstankiewicz
approved these changes
Jun 22, 2022
long74100
force-pushed
the
add-hot-jars-lib
branch
from
1dcd2d3
to
38eaf6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hotjar package so that we can move away from relying on
react-use-hotjarwhich was causing dependency errors in our mfes. It will also give us control over hotjar functionality from now on.Will need to go back, fix hook errors, and remove /* eslint-disable react-hooks/exhaustive-deps */ from files.
Merge checklist:
frontend-app-learner-portal-enterprise,frontend-app-admin-portal, andfrontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGEso the NPM package is released as such.Post merge:
chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.jsonGithub Action workflow to publish these new package versions to NPM.masterbranch.npm view <package_name> versions --json).