Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading path lib in requirements #91

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Upgrading path lib in requirements #91

merged 1 commit into from
Nov 6, 2020

Conversation

awaisdar001
Copy link
Contributor

@awaisdar001 awaisdar001 commented Nov 5, 2020

  1. Remove the path.py from the base.in file.
  2. Added path in the base.in file
  3. Run make upgrade
  4. Stop testing for python3.5 as path is only compatible with python 3.6 and higher.
  5. Update the version in the __init__.py

FYI -- @crice100
PROD-2223

@coveralls
Copy link

coveralls commented Nov 5, 2020

Coverage Status

Coverage increased (+0.2%) to 91.105% when pulling 58b6a03 on aj/update-deps into 58072c0 on master.

Copy link

@crice100 crice100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awaisdar001
Copy link
Contributor Author

@crice100 Thanks, Updated the PR with the version bump.

Do I need to draft a new release on GitHub as well after the merge?

i18n/__init__.py Outdated
@@ -6,7 +6,7 @@

from . import config

__version__ = '0.5.0'
__version__ = '0.5.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 0.5.4 (it looks to me like there were a few releases that were tagged without this file being updated).

https://github.com/edx/i18n-tools/releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!!

Copy link

@crice100 crice100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks.

To answer your question, I think it would make sense to release this, assuming that the standard testing process for this repo (whatever that is) has been followed.

@awaisdar001 awaisdar001 merged commit eed8e50 into master Nov 6, 2020
@awaisdar001 awaisdar001 deleted the aj/update-deps branch November 6, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants