-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading path lib in requirements #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: update the version in https://github.com/edx/i18n-tools/blob/master/i18n/__init__.py
8ffa420
to
d14aa28
Compare
@crice100 Thanks, Updated the PR with the version bump. Do I need to draft a new release on GitHub as well after the merge? |
i18n/__init__.py
Outdated
@@ -6,7 +6,7 @@ | |||
|
|||
from . import config | |||
|
|||
__version__ = '0.5.0' | |||
__version__ = '0.5.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 0.5.4 (it looks to me like there were a few releases that were tagged without this file being updated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha!!
d14aa28
to
58b6a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, thanks.
To answer your question, I think it would make sense to release this, assuming that the standard testing process for this repo (whatever that is) has been followed.
path.py
from thebase.in
file.path
in thebase.in
filemake upgrade
path
is only compatible with python 3.6 and higher.__init__.py
FYI -- @crice100
PROD-2223