Declare OEP-7 compliance #104
Conversation
jmbowman
commented
May 15, 2019
•
jmbowman
commented
- Test Python 2.7 in Travis again
- Switch from testing Python 3.5 to 3.6
- Drop support for testing against Django 1.8
- Update requirements
- Fix new pylint warnings
- Declare OEP-7 support
- Update ownership metadata
|
Closing and reopening to trigger a Travis CI build (it wasn't configured correctly). |
| oeps: {} | ||
| owner: edx/platform-team | ||
| oeps: | ||
| oep-7: true |
There was a problem hiding this comment.
also, oep-2 and oep-18 compliant?
| URL_RE_SOURCE = r""" | ||
| (?P<org>{ALLOWED_ID_CHARS}+)\+(?P<course>{ALLOWED_ID_CHARS}+)\+(?P<run>{ALLOWED_ID_CHARS}+)\+ | ||
| (?P<block_type>{ALLOWED_ID_CHARS}+)\+ | ||
| URL_RE_SOURCE = u""" |
There was a problem hiding this comment.
There are backslashes in the ALLOWED_ID_CHARS var, do those need to be updated as well?
There was a problem hiding this comment.
No, the r at the start of a string literal only affects how characters shown explicitly in the source code for that string literal are treated. (The combined ur prefix no longer exists in Python 3, hence why we need the escaping here).
There was a problem hiding this comment.
ok, so the contents of the var will be escaped correctly before the strings are combined?
There was a problem hiding this comment.
Yes, its content is independent of the prefixes used for the string literal referencing it.
