fix: do not set a default id for Icon component

[mtyaka]

Setting the id property in Icon.defaultProps to newId('Icon') makes every Icon that doesn't explicitly provide an id have an identical id property, since newId('Icon') gets eveluated at module load time. Duplicate ids are not valid HTML.

We are already invoking newId('Icon') inside the Icon component's render method if no id is provided, so we can safely set the id in defaultProps to undefined and let the default id get generated at render time.

Testing instructions

1. Without this patch: Render two or more <Icon> components on a page. Notice that they all have the same id ('Span1').
2. Do the same with this patch. Notice that the ids are no longer identical.

Reviewers:

• @pkulkark
• edX

[openedx-webhooks]

Thanks for the pull request, @mtyaka! I've created OSPR-3744 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

• supporting documentation
• edx-code email threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

[coveralls]

Coverage remained the same at 88.285% when pulling c3b1853 on open-craft:mtyaka/fix-icon-ids into 623d750 on edx:master.

[pkulkark]

@mtyaka LGTM 👍

[natabene]

@mtyaka Thank you for your contribution. @edx/fedx-admin can you give this a look when you have a chance?

[abutterworth]

👍LGTM

[natabene]

👍LGTM

@abutterworth Thank you. Good to merge or do you want another review from edX?

[abutterworth]

@natabene I posted in Slack. I can merge this at the end of the day if no one brings up any concerns.

[openedx-webhooks]

@mtyaka 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-semantic-release]

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[mtyaka]

Thanks everyone! :)