Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filtercheckbox filterchoices properly renders number 0 #816

Merged
merged 1 commit into from Sep 20, 2021
Merged

fix: filtercheckbox filterchoices properly renders number 0 #816

merged 1 commit into from Sep 20, 2021

Conversation

manny-m
Copy link
Contributor

@manny-m manny-m commented Sep 17, 2021

Small conditional change to 0 is rendered properly on filter label.
Before:
Screen Shot 2021-09-17 at 2 05 05 PM

After:
Screen Shot 2021-09-17 at 2 04 24 PM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.611% when pulling 0b40d3f on PAR-574 into 70dfedd on master.

long74100
long74100 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@long74100 long74100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@manny-m manny-m merged commit 628b3cd into master Sep 20, 2021
@manny-m manny-m deleted the PAR-574 branch September 20, 2021 13:07
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 16.14.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdiesel macdiesel macdiesel approved these changes

@long74100 long74100 long74100 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manny-m @coveralls @edx-semantic-release @macdiesel @long74100