New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower-ifying the UX Pattern Library #136
Comments
Thanks, @Nickersoft, for the good thoughts and inspiration. FYI, I just merged in #152 which moves our basic UXPL Sass partials and utilities into a Bower package. :) Also, I've got a few more updates in the works for some of your other points:
Hope that helps keep you updated. I'll check back in on this issue in a bit to see if you have any ideas around how to get the PLDOC site using the actual bower package. |
@Nickersoft, following up a bit...
I think this has been done through the bower package and its ignore settings. One can now install the package and use the full library without all of the doc site files. Currently, we still need a testbed to build new library patterns. Documenting them while doing so is a bonus :) With that said, I think this (along with my original comments) addresses all of your feedback. I'm close this with that mind. Thanks much for the good inspiration. If something else comes up or you think we need a deeper dive into anything here, feel free to comment or open a new issue. |
As a developer from another team who uses the pattern library, I think it is crucial that proper Bower support be integrated with the pattern library (my original thought was NPM, but edX as an organization uses Bower to manage front-end dependencies). I tried playing around in my own branch, but ultimately this change is significant enough to warrant a dedicated effort. Some suggestions I have that could help this effort:
main-*.scss
file, which currently resides in the documentation section of the repo. This makes it confusing for developers who wish to plug-and-play the library with little configuration. There should be apattern-library-ltr.scss
file as well as apattern-library-rtl.scss
file, which includes all of the needed imports.main-ltr.scss
andmain-rtl.scss
. These dependencies should be formally documented in a README. JS dependencies wouldn't need to be documented given there is a compiled production version of the Javascript.This is more of something to keep in mind, nothing extremely pressing. Just thoughts from someone who has tried using the pattern library. Let me know if you have any questions or comments. Thanks!
@talbs @frrrances
The text was updated successfully, but these errors were encountered: