Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag and use it for LTI1.3 [BD-38] [BB-3899] [TNL-8104] #172

Merged
merged 1 commit into from Jul 8, 2021
Merged

refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag and use it for LTI1.3 [BD-38] [BB-3899] [TNL-8104] #172

merged 1 commit into from Jul 8, 2021

Conversation

xitij2000
Copy link
Contributor

@xitij2000 xitij2000 commented Jun 16, 2021 •
edited by awaisdar001

This commit renames the CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag since the aim is to expand its scope to all LTI-related PII sharing. It also removes the current LTI1.3 waffle flag for PII sharing.

TNL-8104

@xitij2000 xitij2000 requested a review from a team June 16, 2021 12:35
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 16, 2021 •
edited

Thanks for the pull request, @xitij2000! I've created BLENDED-894 to keep track of it in Jira.

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 16, 2021
@xitij2000 xitij2000 changed the title refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag and use it for LTI1.3 refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag and use it for LTI1.3 [BD-38] [BB-3899] Jun 16, 2021
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Jun 16, 2021
@xitij2000 xitij2000 force-pushed the kshitij/bb-3899/pii-flag-cleanup branch from a7d8393 to 498bc54 Compare June 23, 2021 11:30
@coveralls
Copy link

coveralls commented Jun 23, 2021 •
edited

Coverage Status

Coverage remained the same at 0.0% when pulling 6fb8679 on open-craft:kshitij/bb-3899/pii-flag-cleanup into 5579620 on edx:master.

nedbat
nedbat suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@nedbat nedbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
lti_consumer/models.py Outdated Show resolved Hide resolved
@nedbat
Copy link
Contributor

nedbat commented Jun 23, 2021

@giovannicimolin any concerns?

@asadazam93
Copy link

@xitij2000 Can you please create a TNL ticket for this and add a detailed description?

@asadazam93
Copy link

@xitij2000 How do you plan to backfill data?

@xitij2000
Copy link
Contributor Author

@xitij2000 How do you plan to backfill data?

I'm not sure I follow. What data needs to be backfilled?

@xitij2000 xitij2000 mentioned this pull request Jun 25, 2021
Merged
2 tasks
@asadazam93
Copy link

@xitij2000 How do you plan to backfill data?

I'm not sure I follow. What data needs to be backfilled?

You are changing the name of the model. How do you plan to fill data from the previous model into the new model?

@xitij2000
Copy link
Contributor Author

@asadazam93 Changing the name of a model doesn't do anything to the data. The table is renamed, so the data is retained. In ths case, since the table name is also set, it won't be renamed either.

@xitij2000 xitij2000 force-pushed the kshitij/bb-3899/pii-flag-cleanup branch 3 times, most recently from 4c8d008 to 67160c5 Compare July 1, 2021 04:38
@xitij2000
refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIIShar…
6fb8679 
…ingInLTIFlag and use it for LTI1.3

This commit renames the CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag since the aim is to expand its scope to all LTI-related PII sharing. It also removes the current LTI1.3 waffle flag for PII sharing.
@xitij2000 xitij2000 force-pushed the kshitij/bb-3899/pii-flag-cleanup branch from 67160c5 to 6fb8679 Compare July 1, 2021 13:40
awaisdar001
awaisdar001 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@awaisdar001 awaisdar001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@asadazam93
Copy link

@xitij2000 This PR is still missing a TNL ticket. Can you please create one and add to the description? Let us merge the PR after the ticket is created

@xitij2000 xitij2000 changed the title refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag and use it for LTI1.3 [BD-38] [BB-3899] refactor: Rename CourseEditLTIFieldsEnabledFlag to CourseAllowPIISharingInLTIFlag and use it for LTI1.3 [BD-38] [BB-3899] [TNL-8104] Jul 5, 2021
@xitij2000
Copy link
Contributor Author

@asadazam93 I've added the ticket number to the PR title.

@awaisdar001
Copy link
Contributor

Thanks, @xitij2000 can this be merged?

@xitij2000
Copy link
Contributor Author

@awaisdar001 Yes, however https://github.com/edx/edx-platform/pull/26982 will need to be adjusted right after, so I would prefer if we do this during early IST hours.

@asadazam93
Copy link

@xitij2000 Let us merge both PRs during our meeting tomorrow morning?

@xitij2000
Copy link
Contributor Author

@xitij2000 Let us merge both PRs during our meeting tomorrow morning?

That might not be possible. After this PR is merged, it would still be nice to run the edx-platform tests to make sure nothing is broken. That would take some time.

@awaisdar001
Copy link
Contributor

@xitij2000 Let us merge both PRs during our meeting tomorrow morning?

That might not be possible. After this PR is merged, it would still be nice to run the edx-platform tests to make sure nothing is broken. That would take some time.

we can merge this PR in standup -- and secondly we should get in touch on Slack when the other PR in edx-platform needs to be merged.

@awaisdar001 awaisdar001 merged commit 1b1f380 into openedx:master Jul 8, 2021
@xitij2000 xitij2000 deleted the kshitij/bb-3899/pii-flag-cleanup branch July 14, 2021 05:22
@Agrendalath Agrendalath mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedbat nedbat nedbat requested changes

@awaisdar001 awaisdar001 awaisdar001 approved these changes

@asadazam93 asadazam93 asadazam93 approved these changes

Assignees

@asadazam93 asadazam93

@AhtishamShahid AhtishamShahid

Labels
blended PR is managed through 2U's blended developmnt program merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xitij2000 @openedx-webhooks @coveralls @nedbat @asadazam93 @awaisdar001 @AhtishamShahid