[BD-2] BB-2365: Merge LTI 1.3 support to master. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features: Implement LTI 1.3 launch support. Add LTI 1.3 passthrough views as LMS plugins.
Features: Implement LTI 1.3 launch support. Add LTI 1.3 passthrough views as LMS plugins.
This commit adds support for the LTI 1.3 Access token endpoint, as detailed in the IMS Security Framework. The token is generated using the consumer's private key (stored in the XBlock) after validating the message sent by the LTI Tool using it's public key. Signed-off-by: Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
Signed-off-by: Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
Also fixes a few untreated exceptions and remove unused variables. Signed-off-by: Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
|
Thanks for the pull request, @giovannicimolin! I've created OSPR-4755 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
k# Please enter the commit message for your changes. Lines starting
giovannicimolin
force-pushed
the
giovanni/bb-2365-merge-to-prod
branch
from
e217e3a
to
d020659
Compare
giovannicimolin
changed the title
|
@giovannicimolin 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
openedx-webhooks
added
blended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the feature branch that implements LTI 1.3 launch support.
Already tested and approved by edX team on review branch.
Testing instructions:
Reviewers: