Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCKIN-8266] <span> and <i> Tags are being removed fixed in tinymce. #62

Merged

Conversation

@LanghaniKuldeep
Copy link
Contributor

LanghaniKuldeep commented Aug 2, 2019

In TinyMCE's html editor eliminates span and i tags on saving that. We are not able to use those tags, therefore, this PR extends valid tags and put them in the list.

@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Aug 2, 2019

Thanks for the pull request, @LanghaniKuldeep! I've created OSPR-3771 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information.

@LanghaniKuldeep LanghaniKuldeep changed the title <span> and <i> Tags are being removed fixed in tinymce. [MCKIN-8266] <span> and <i> Tags are being removed fixed in tinymce. Aug 2, 2019
@natabene

This comment has been minimized.

Copy link
Member

natabene commented Aug 2, 2019

@LanghaniKuldeep Thank you for the contribution! When you have a chance, could you please send in a signed Contributor Agreement mentioned in the earlier comment? You only need to do this once and we can then review all your future code contributions. Thanks
If you are affiliated with a company that already has an institution agreement with edX, please have someone from your company verify to us.

@LanghaniKuldeep

This comment has been minimized.

Copy link
Contributor Author

LanghaniKuldeep commented Aug 5, 2019

@natabene Thankyou for your comment. I am associated with Arbisoft. Can you assign someone from the team to review this PR?

@nedbat

This comment has been minimized.

Copy link
Member

nedbat commented Aug 5, 2019

This seems like a fine change. 👍

@natabene natabene merged commit a192217 into edx:master Aug 5, 2019
3 checks passed
3 checks passed
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Aug 5, 2019

@LanghaniKuldeep 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@LanghaniKuldeep

This comment has been minimized.

Copy link
Contributor Author

LanghaniKuldeep commented Aug 6, 2019

@natabene @nedbat Thanks for merging.
Can anyone of please create a new Release Tag for this fix so that I can use the updated one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.