Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Analytics support needs to be upgraded #120

Closed
eecs441staff opened this issue Mar 30, 2021 · 0 comments · Fixed by #121
Closed

Google Analytics support needs to be upgraded #120

eecs441staff opened this issue Mar 30, 2021 · 0 comments · Fixed by #121
Labels
bug Something isn't working

Comments

@eecs441staff
Copy link

Describe the bug

Primer-spec supports for google analytics still relies on Google's analytics.js script whereas Google has switched to gtag.js

https://developers.google.com/analytics/devguides/collection/upgrade/analyticsjs

Additional context

This page documents gtag.js:

https://developers.google.com/analytics/devguides/collection/gtagjs/
@eecs441staff eecs441staff added the bug Something isn't working label Mar 30, 2021
@seshrs seshrs mentioned this issue Mar 31, 2021
Merged
@seshrs seshrs closed this as completed Mar 31, 2021
@seshrs seshrs linked a pull request Mar 31, 2021 that will close this issue
Update Google Analytics snippet to use gtag.js #121
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Google Analytics snippet to use gtag.js eecs485staff/primer-spec
2 participants
@seshrs @eecs441staff