Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Option for saves history of searched words #23

Open
Spuxy opened this issue Sep 8, 2023 · 5 comments
Open

Feature request: Option for saves history of searched words #23

Spuxy opened this issue Sep 8, 2023 · 5 comments

Comments

@Spuxy
Copy link

Spuxy commented Sep 8, 2023

Like this title says. I would like to add option to make me separetly files/makrdown whatever of my history of specific translated words.

I can make PR for that but i would like to know if there is anyone who would use this option aswell.

My idea would be:
Keybind: ctrl + shift + s (as save)
Creates file {source_language}_{destination_language}.md

Of course the style of naming of these files could be override by some configuration file.

@eeeXun
Copy link
Owner

eeeXun commented Sep 9, 2023

PR always welcome. But I'm not sure that if the TUI framework can detect ctrl+shift. I think the ideal key should be ctrl with other key.

Also, I'm curious what is the use case for this feature?

@Spuxy
Copy link
Author

Spuxy commented Sep 11, 2023

Sorry maybe i have sent it when i was rushed at work. But use case (atleast mine) is local history file which words i did not know in english to learn/practice to not search them next time 🫠

@eeeXun
Copy link
Owner

eeeXun commented Sep 16, 2023

What format should be saved given a SRC_WORD and a DST_WORD. Do you have any idea or proposal?

@Spuxy
Copy link
Author

Spuxy commented Sep 25, 2023

No I don't, but as a user, it does not really matter as long as it saves words, it could be really random format.
It is nice to have feature but it's not necessary. I can make PR for this feature if u don't mind.

@eeeXun
Copy link
Owner

eeeXun commented Sep 25, 2023

I can make PR for this feature if u don't mind.

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants