Skip to content

Commit

Permalink
Rework DBC long name dump.
Browse files Browse the repository at this point in the history
  • Loading branch information
@eerimoq
eerimoq committed Jan 6, 2020
1 parent f22c8b4 commit 89b974c
Show file tree
Hide file tree
Showing 4 changed files with 351 additions and 398 deletions.

3 comments on commit 89b974c

@geo4711
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I've seen your effort for rework …
However, there's one aspect which doesn't work now anymore (compare to my version):

  • import a database with a long name message (would be the same for signal or node)
  • modify the name (new name <= 32 chars)
  • dump dbc to a new file
  • open the new dbc --> the message will have it's original name again!
    Reason:
  • The first import also stores the attribute with the long name
  • When dumping the modified database, this attribute still exists, and it still contains the long name

Can you confirm this effect?

@eerimoq
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are probably right. Can you create a test case for this problem and possibly a fix?

@geo4711
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll bring up a tiny PR (hopefully within the next days)

Please sign in to comment.