DBC: write cycle time #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cycle time is already parsed, it was just not written: The idea of
this patch is to write attributes which are directly represented by
Signal() or Message() objects without relying on the
`{signal,message}.dbc` sub-object. The rationale for this is that the
user might have loaded a database from a file, then manipulated a few
attributes and then writes back a DBC file. (thus,
`{signal,message}.dbc` may be present or not, and the respective
attribute might be defined and consistent with the rest of the object
or not.)
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: Oliver Kopp <oliver.kopp@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Oliver Kopp <oliver.kopp@mbition.io>
this changes the output level of the logger for most test from DEBUG to WARNING.. IMO the DEBUG log level only ought to be of interest during development/debugging but not when running unit tests... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Oliver Kopp <oliver.kopp@mbition.io>
andlaus
force-pushed
the
DBC_write_cycle_time
branch
from
0ed0361
to
7fb7837
Compare
|
Mainly housekeeping covered by tests. Outputting cycle time is good, tty verbosity reduction, too. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes out the cycle times of messages in
cantools.database.dump_file(). I also took the liberty of reducing the TTY noise of the tests somewhat...Andreas Lauser <andreas.lauser@daimler.com>, on behalf of MBition GmbH.
Provider Information