Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jsonification to given #308

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

Kudbettin
Copy link
Member

Addresses #307, but does not fix it completely.

One of the issue's problems is that the stash contains "to be jsonified" contents. When it has does not alter the contents of the resources in stash and ends up passing a badly formatted stash. The problem doesn't occur with When it contains because it drills down to the jsonified value.

This is an aggressive solution to a simple problem. The other option I came up with was jsonifying the entities in the stash during WHEN. However, altering contents of the resources during WHEN seemed to be an exception against "WHEN filters"

Since everything will already be jsonified, jsonify calls on step functions can be removed as well.

@coveralls
Copy link

coveralls commented Jun 26, 2020

Pull Request Test Coverage Report for Build 1077

  • 14 of 20 (70.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 59.666%

Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/common/helper.py 10 11 90.91%
terraform_compliance/steps/given/i_have_name_section_configured.py 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
terraform_compliance/common/defaults.py 6 83.78%
Totals Coverage Status
Change from base Build 1070: 0.5%
Covered Lines: 1216
Relevant Lines: 2038

💛 - Coveralls

@eerkunt eerkunt merged commit d36dd7c into terraform-compliance:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants