Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python version check #312

Merged
merged 7 commits into from
Jul 4, 2020
Merged

Python version check #312

merged 7 commits into from
Jul 4, 2020

Conversation

eerkunt
Copy link
Member

@eerkunt eerkunt commented Jul 4, 2020

  • Implemented python_version_check to ensure minimum supported Python version is 3.6.0

@eerkunt eerkunt requested a review from Kudbettin July 4, 2020 11:06
@coveralls
Copy link

coveralls commented Jul 4, 2020 •
edited

Pull Request Test Coverage Report for Build 1088

  • 14 of 18 (77.78%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 59.513%
Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/main.py 1 2 50.0%
terraform_compliance/common/helper.py 11 14 78.57%
Totals Coverage Status
Change from base Build 1082: 0.1%
Covered Lines: 1223
Relevant Lines: 2055
💛 - Coveralls

Kudbettin
Kudbettin requested changes Jul 4, 2020
View reviewed changes
terraform_compliance/main.py Outdated Show resolved Hide resolved
tests/terraform_compliance/common/test_helper.py Show resolved Hide resolved
@eerkunt eerkunt merged commit e5d5763 into master Jul 4, 2020
@eerkunt eerkunt deleted the python-version-check branch July 4, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudbettin Kudbettin Kudbettin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eerkunt @coveralls @Kudbettin