Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueType.isParsable should be removed #696

Closed
eeverman opened this issue Nov 15, 2021 · 1 comment
Closed

ValueType.isParsable should be removed #696

eeverman opened this issue Nov 15, 2021 · 1 comment
Milestone

Comments

@eeverman
Copy link
Owner

eeverman commented Nov 15, 2021

ValueType.isParsable is never used except by tests and there is no good reason to call it. Directly calling parse and getting the error gives the information that is needed to display to the user, whereas the isParsable method doesn't explain why its not parsable.

Related: Since nulls are handled either by a default value or a non-null constraint, the `ValueType.parse' method should clearly state that it does not expect nulls. Its OK for it to continue to check for nulls and the appropriate response would be null.

@eeverman eeverman added this to the 0.5.0 milestone Nov 15, 2021
@eeverman eeverman changed the title BaseLoader should always parse values, not skip nulls ValueType.parse should say it doesn't expect nulls Nov 21, 2021
@eeverman eeverman changed the title ValueType.parse should say it doesn't expect nulls ValueType.isParsable should be removed Nov 21, 2021
@eeverman eeverman mentioned this issue Nov 21, 2021
5 tasks
@eeverman
Copy link
Owner Author

Fixed by #705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant