Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Sit nor Break Chairs #3

Closed
200Tigersbloxed opened this issue Mar 26, 2024 · 3 comments
Closed

Cannot Sit nor Break Chairs #3

200Tigersbloxed opened this issue Mar 26, 2024 · 3 comments

Comments

@200Tigersbloxed
Copy link

When placing any sort of chair; such as a sofa, bench, chair, stool, etc., the chair cannot be sat in (at least by a player) and cannot be broken correctly. The bounding box is removed, but the chair model still stays visibly present, until the datapack is uninstalled.

2024-03-26_09 07 05

2024-03-26_09 07 18

Currently using Fabric 1.20.1 with the Data loader mod to load the datapack into all worlds. I have noticed this also happens regardless of using a mod loader or not, and whether or not you are using a server or client (multiplayer/singleplayer).

Let me know if I can provide any more information!

@200Tigersbloxed
Copy link
Author

After doing more research, 1.20.2 is also affected. The reason is most likely due to a missing tag.

[Worker-Main-20/ERROR]: Couldn't load tag ketket_furnitures:cantsit as it is missing following references: minecraft:wind_charge (from file/furnicraft v2.25)

This is output in the logs on both 1.20.1 and 1.20.2, but not on 1.20.3 and 1.20.4 (the two versions that work fine).

@200Tigersbloxed
Copy link
Author

Sure enough, removing line 35 from cantsit.json fixes the issue for 1.20.1 and 1.20.2!

Here is the edited cantsit.json for a quick fix.

{
    "replace": false,
    "values": [
        "minecraft:interaction",
        "minecraft:item",
        "minecraft:item_display",
        "minecraft:block_display",
        "minecraft:armor_stand",
        "minecraft:item_frame",
        "minecraft:player",
        "minecraft:experience_orb",
        "minecraft:arrow",
        "minecraft:area_effect_cloud",
        "minecraft:dragon_fireball",
        "minecraft:end_crystal",
        "minecraft:ender_pearl",
        "minecraft:evoker_fangs",
        "minecraft:eye_of_ender",
        "minecraft:falling_block",
        "minecraft:fireball",
        "minecraft:firework_rocket",
        "minecraft:glow_item_frame",
        "minecraft:leash_knot",
        "minecraft:lightning_bolt",
        "minecraft:llama_spit",
        "minecraft:marker",
        "minecraft:painting",
        "minecraft:small_fireball",
        "minecraft:text_display",
        "minecraft:tnt",
        "minecraft:potion",
        "minecraft:snowball",
        "minecraft:wither_skull",
        "minecraft:experience_bottle",
        "minecraft:fishing_bobber",
        "minecraft:egg",
        "minecraft:shulker_bullet",
        "minecraft:trident",
        "#minecraft:arrows"
    ]
}

@efeketket
Copy link
Owner

efeketket commented Apr 4, 2024

Thank you for taking the time to fix this! I missed the "minecraft:wind_charge" tag that was added in 1.20.3. I'll fix it.

Here is the new version https://modrinth.com/datapack/ketkets-furnicraft/version/2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants