Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From Discord: Issue with minigit clone command behavior #1852

Closed
effect-bot opened this issue Jan 3, 2024 · 0 comments · Fixed by #1853
Closed

From Discord: Issue with minigit clone command behavior #1852

effect-bot opened this issue Jan 3, 2024 · 0 comments · Fixed by #1853

Comments

@effect-bot
Copy link

Summary

The user is experiencing an issue with the minigit clone command behavior in the Effect-TS ecosystem. They noticed that the directory argument, which is tagged as optional, is not being handled correctly in the Command.make() handler. The config.directory is being treated as a raw string instead of an Option, causing ReadonlyArray.getSomes() to exclude it. The user suspects that the issue lies in the Args.optional function not properly wrapping the argument with Option.some.

Discord thread

https://discord.com/channels/795981131316985866/1191958676756512921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Issues Management
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Args.optional returning Option Effect-TS/effect
1 participant
@effect-bot