Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From Discord: Missing Annotations from Interface in Effect-TS Schema #2548

Closed
effect-bot opened this issue Apr 17, 2024 · 0 comments · Fixed by #2550
Closed

From Discord: Missing Annotations from Interface in Effect-TS Schema #2548

effect-bot opened this issue Apr 17, 2024 · 0 comments · Fixed by #2550
Labels

Comments

@effect-bot
Copy link

Summary

The conversation revolves around an observation made by a user, patroza, who pointed out that certain annotations present in the Effect-TS schema code (specifically at line 6586) are missing from an interface (at line 6235) within the same file. Another user, gcanti, responded, suggesting that this discrepancy appears to be an oversight. This exchange was lightly commented on by datner_, who humorously remarked on the situation, implying that such an oversight contradicts the expectation of strictness in the codebase.

Key Takeaways:

  1. Oversight in Code: The discussion highlights a potential oversight in the Effect-TS schema, where annotations present in one part of the code are missing from an interface, suggesting a lack of alignment or an unintended omission.
  2. Community Engagement: The interaction shows active engagement from the community in reviewing and discussing the codebase, indicating a collaborative effort in identifying and possibly rectifying inconsistencies or errors.
  3. Importance of Strictness: datner_'s comment underscores the expectation of strictness and consistency in the code, especially in projects like Effect-TS, which are likely to be used in environments where reliability and precision are critical.
  4. Open Source Collaboration: The exchange exemplifies how open-source projects benefit from community involvement, where users can directly point out potential issues, contributing to the improvement and robustness of the software.

Discord thread

https://discord.com/channels/795981131316985866/1230038841428021258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants