-
Notifications
You must be signed in to change notification settings - Fork 16
/
no-getState.js
74 lines (64 loc) · 1.88 KB
/
no-getState.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
const {
traverseNestedObjectNode,
} = require("../../utils/traverse-nested-object-node");
module.exports = {
meta: {
type: "problem",
docs: {
description: "Forbids `.getState` calls on any Effector store",
category: "Quality",
recommended: true,
},
messages: {
abusiveCall:
"Method `.getState` called on store `{{ storeName }}` can lead to race conditions. Replace it with `sample` or `guard`.",
},
schema: [],
},
create(context) {
const parserServices = context.parserServices;
return {
CallExpression(node) {
const methodName = node.callee?.property?.name;
if (methodName !== "getState") {
return;
}
const object = traverseNestedObjectNode(node.callee?.object);
const objectName = object?.name;
if (!objectName) {
return;
}
// TypeScript-way
if (parserServices.hasFullTypeInformation) {
const checker = parserServices.program.getTypeChecker();
const originalNode = parserServices.esTreeNodeToTSNodeMap.get(object);
const type = checker.getTypeAtLocation(originalNode);
const isEffectorStore =
type?.symbol?.escapedName === "Store" &&
type?.symbol?.parent?.escapedName?.includes("effector");
if (!isEffectorStore) {
return;
}
reportGetStateCall({ context, node, storeName: objectName });
}
// JavaScript-way
else {
const isEffectorStore = objectName.startsWith("$");
if (!isEffectorStore) {
return;
}
reportGetStateCall({ context, node, storeName: objectName });
}
},
};
},
};
function reportGetStateCall({ context, node, storeName }) {
context.report({
node,
messageId: "abusiveCall",
data: {
storeName,
},
});
}