-
Notifications
You must be signed in to change notification settings - Fork 16
/
strict-effect-handlers.js
56 lines (49 loc) · 1.53 KB
/
strict-effect-handlers.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
const { createLinkToRule } = require("../../utils/create-link-to-rule");
const { is } = require("../../utils/is");
module.exports = {
meta: {
type: "problem",
docs: {
description:
"Forbids mix of async functions and effects calls in effect handlers.",
category: "Quality",
recommended: true,
url: createLinkToRule("strict-effect-handlers"),
},
messages: {
mixedCalls:
"Handler of effect `{{ effectName }}` can lead to scope loosing in Fork API.",
},
schema: [],
},
create(context) {
function onEffectHandler(node) {
if (!node.body?.body) {
return;
}
const effectName = node.parent?.parent?.id?.name ?? "Unknown";
const handlerBody = node.body.body;
const calledNodes = handlerBody
.filter((bodyNode) => bodyNode.expression?.type === "AwaitExpression")
.map((awaitNode) => awaitNode.expression.argument.callee);
const hasEffects = calledNodes.some((calledNode) =>
is.effect({ context, node: calledNode })
);
const hasRegularAsyncFunctions = calledNodes.some((calledNode) =>
is.not.effect({ context, node: calledNode })
);
if (hasEffects && hasRegularAsyncFunctions) {
context.report({
node: node.parent,
messageId: "mixedCalls",
data: { effectName },
});
}
}
return {
ArrowFunctionExpression: onEffectHandler,
FunctionExpression: onEffectHandler,
FunctionDeclaration: onEffectHandler,
};
},
};