Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: no-on #117

Open
igorkamyshev opened this issue Aug 29, 2022 · 3 comments · May be fixed by #157
Open

Rule: no-on #117

igorkamyshev opened this issue Aug 29, 2022 · 3 comments · May be fixed by #157
Labels
enhancement New feature or request good first issue Good for newcomers preset:strict

Comments

@igorkamyshev
Copy link
Member

$store.on is less extendable than sample, and it could be replaced with sample. Let's add a rule to check this.

In my mind, we should not add it to recommended preset, but it would be useful in future preset (maybe).
@igorkamyshev igorkamyshev added enhancement New feature or request good first issue Good for newcomers labels Aug 29, 2022
@sergeysova
Copy link
Collaborator

It would be useful in kind of strict preset

@gearonix
Copy link
Contributor

Still valid? Sounds cool

@igorkamyshev
Copy link
Member Author

Still valid? Sounds cool

Yep, I think so. PRs are welcome 🙏

@gearonix gearonix linked a pull request Feb 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers preset:strict
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rule no-on gearonix/effector-eslint-plugin
3 participants
@sergeysova @igorkamyshev @gearonix