Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: no-effects-in-components #130

Open
San4es opened this issue Dec 9, 2022 · 0 comments
Open

Rule: no-effects-in-components #130

San4es opened this issue Dec 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@San4es
Copy link

San4es commented Dec 9, 2022

Using effects in components typically leads to business logic leaks into view. A cleaner approach is to use events instead of effects.
I suggest to add corresponding rule to warn a user about it.

// Fail
function Component() {
  useUnit(someFx)
  useEvent(someFx)
  useEffect(() => {
    someFx()
    () => someFx()
  }, [])
  const callback = () => {
    someFx()
  }
  useCallback(() => {
    someFx()
  }, [])
}
@sergeysova sergeysova added the enhancement New feature or request label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants