Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive trigger for enforce-store-naming-convention #136

Closed
Kelin2025 opened this issue Mar 9, 2023 · 0 comments · Fixed by #137
Closed

False positive trigger for enforce-store-naming-convention #136

Kelin2025 opened this issue Mar 9, 2023 · 0 comments · Fixed by #137
Labels
bug Something isn't working

Comments

@Kelin2025
Copy link
Member

Kelin2025 commented Mar 9, 2023

Sometimes plugin treats factories from effector-factorio as stores

Minimal reproduction code

import { combine, sample } from 'effector'
import { modelFactory } from 'effector-factorio'

export const factory = modelFactory(() => {
  sample({
    clock: combine([createStore('')]),
    fn: ([fieldType, customFieldId]) => customFieldId || fieldType,
    target: createStore(''),
  })

  return {}
})

Result:
Screenshot 2023-03-09 at 20 22 29

Parser: @typescript-eslint/parser (5.53.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants