Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 8 #56

Merged
merged 7 commits into from Oct 12, 2021
Merged

ESLint 8 #56

merged 7 commits into from Oct 12, 2021

Conversation

igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented Oct 6, 2021

fixes #52

We are ready! Just waiting for releases:

  • typescript-eslint v5
  • eslint v8

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Total Coverage: 96.34%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Total Coverage: 96.04%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 75% 100% 93.33% 55, 59, 60, 72, 73
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@binjospookie
Copy link
Sponsor Contributor

typescript-eslint@5 and eslint@8 were released :)

@igorkamyshev
Copy link
Member Author

typescript-eslint@5 and eslint@8 were released :)

Thanks!

Actually, 0.4.0 has already supported ESLint 8. So, you can upgrade ESLint in your project.

This PR affects only tests.

@github-actions
Copy link

Total Coverage: 96.04%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 75% 100% 93.33% 55, 59, 60, 72, 73
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@igorkamyshev igorkamyshev marked this pull request as ready for review October 12, 2021 10:45
@igorkamyshev igorkamyshev merged commit a5f9244 into master Oct 12, 2021
@igorkamyshev igorkamyshev deleted the eslint-8 branch October 12, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for ESLInt 8.0.0
2 participants