Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule no-duplicate-on #85

Closed
alatielle opened this issue Jan 31, 2022 · 1 comment · Fixed by #86
Closed

Rule no-duplicate-on #85

alatielle opened this issue Jan 31, 2022 · 1 comment · Fixed by #86
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alatielle
Copy link

The linter throws an error
"ESLint: Method .on is called on store undefined more than once for inputs.changeReturnDate.(effector/no-duplicate-on)"
when .on is applied to a store through an object property (outputs.$something). The error goes away when the store containing object is destructured
@igorkamyshev
Copy link
Member

Thanks for report. It's definitely a bug.

I'm working on #82 PR, so I'll fix it right after that. Fix will be released in 0.6.0.

@igorkamyshev igorkamyshev added bug Something isn't working good first issue Good for newcomers labels Feb 1, 2022
@igorkamyshev igorkamyshev mentioned this issue Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false-positive in no-duplicate-on effector/eslint-plugin
2 participants
@alatielle @igorkamyshev