Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected components doesn't work properly with Radix UI components with asChild props #68

Closed
Tracked by #44
ghost opened this issue Jun 10, 2023 · 3 comments
Closed
Tracked by #44
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 10, 2023

Reproduce:

If you use reflected component as a children for Radix UI component with asChild prop you will get this error:
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

I think the reason for this error is that the reflected components are not wrapped with forwardRef

@sergeysova sergeysova added the bug Something isn't working label Jun 12, 2023
@sergeysova
Copy link
Contributor

@frkam Thank you for the report.

Would you like to contribute patch to fix the issue?

@ghost
Copy link
Author

ghost commented Jun 12, 2023

@sergeysova Thank you for answer!

Sorry, but I don't have time for this right now :(

@sergeysova sergeysova added this to the v9.0 milestone Jun 14, 2023
@sergeysova
Copy link
Contributor

@frkam Fix was released at https://github.com/effector/reflect/releases/tag/v8.3.2.

Would you like to check and close/comment on this issue?

Thank you @kireevmp for the contribution!

@sergeysova sergeysova removed this from the v9.0 milestone Sep 17, 2023
@sergeysova sergeysova self-assigned this Sep 17, 2023
@ghost ghost closed this as completed Sep 20, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant