Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wget in alpine runs into an endless retry loop #100

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

gesellix
Copy link

@gesellix gesellix commented Jan 8, 2023

The issue appeard in #2: when running tests in an Alpine based container, the test case 9 wget timeout does not double hangs due to other defaults and wget endlessly retrying the request (though wait-for would like to perform those retries :) ).

Copy link
Member

@Addono Addono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although 🤞 that we're not breaking dependents who have some version of wget which doesn't expose this flag 😅 . Anyway, they can stay on the current version.

@Addono Addono merged commit b15c461 into eficode:master Jan 9, 2023
github-actions bot pushed a commit that referenced this pull request Jan 9, 2023
## [2.2.4](v2.2.3...v2.2.4) (2023-01-09)

### Bug Fixes

* `wget` in alpine runs into an endless retry loop ([#100](#100)) ([b15c461](b15c461))
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

🎉 This PR is included in version 2.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gesellix gesellix deleted the alpine-tries branch January 9, 2023 11:50
github-actions bot pushed a commit to danieleagle/wait-for that referenced this pull request Jun 2, 2023
# 1.0.0 (2023-06-02)

### Bug Fixes

* `wget` in alpine runs into an endless retry loop ([eficode#100](https://github.com/danieleagle/wait-for/issues/100)) ([b15c461](b15c461))
* **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5))
* correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/danieleagle/wait-for/issues/16)
* **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/danieleagle/wait-for/issues/82)) ([570c9fb](570c9fb))
* **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308))
* **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c))
* typo in error message for missing wget command ([db2479e](db2479e))
* uses timeout in nc as it is used with wget ([eficode#42](https://github.com/danieleagle/wait-for/issues/42)) ([0195167](0195167))
* wget timeout does not double ([206b38d](206b38d))

### Features

* adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/danieleagle/wait-for/issues/71)
* adds license header to wait-for script ([975d508](975d508))
* adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/danieleagle/wait-for/issues/14)
* **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f))
* **option:** Support more conventional formats in the option parser ([ce95717](ce95717))
* **version:** trigger first release for v1.0.0 ([33f1343](33f1343))

### BREAKING CHANGES

* **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot pushed a commit to fitz7/wait-for that referenced this pull request Dec 9, 2023
# 1.0.0 (2023-12-09)

### Bug Fixes

* `wget` in alpine runs into an endless retry loop ([eficode#100](https://github.com/fitz7/wait-for/issues/100)) ([b15c461](b15c461))
* **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5))
* correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/fitz7/wait-for/issues/16)
* **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/fitz7/wait-for/issues/82)) ([570c9fb](570c9fb))
* **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308))
* **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c))
* typo in error message for missing wget command ([db2479e](db2479e))
* uses timeout in nc as it is used with wget ([eficode#42](https://github.com/fitz7/wait-for/issues/42)) ([0195167](0195167))
* wget timeout does not double ([206b38d](206b38d))

### Features

* adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/fitz7/wait-for/issues/71)
* adds license header to wait-for script ([975d508](975d508))
* adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/fitz7/wait-for/issues/14)
* **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f))
* **option:** Support more conventional formats in the option parser ([ce95717](ce95717))
* **version:** trigger first release for v1.0.0 ([33f1343](33f1343))

### BREAKING CHANGES

* **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants