Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-Peer Code Review #2

Open
5 tasks done
t-bello7 opened this issue Jun 7, 2022 · 0 comments
Open
5 tasks done

Peer-to-Peer Code Review #2

t-bello7 opened this issue Jun 7, 2022 · 0 comments

Comments

@t-bello7
Copy link

t-bello7 commented Jun 7, 2022

Hello @efoosag βœ‹,

Amazing Job so far πŸš€
There are some issues that you still need to work on to go to the next project but you are almost there! 🚨

Highlights ⚑

  • Proper async and await use
  • Proper use of arrow functions

Required Changes ♻️

Check the comments under the review.

  • You should add a description of your project and a live link for easy display of the work done on the project in the readme
  • On line 8 of the index.html file you should move the scripts tag to the last child of the body element
  • In the index.js file you can apply the modular code principle by moving utility functions like display book and reloading to a different module

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant