Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins are clustered into two cluster, that are overlapping each other #49

Closed
IVANKRUPSKI opened this issue Oct 7, 2017 · 11 comments
Closed
Labels

Comments

@IVANKRUPSKI
Copy link

Hey!

Sometimes pins are clustered into more than one cluster, and these clusters are overlapping each other. That is really confusing, sometimes two overlapping cluster pins are exactly on the same place on the map, which looks like a mistake in calculation.

Is that normal, expected behaviour of the framework?

screenshot at oct 07 16-56-42

@IVANKRUPSKI IVANKRUPSKI changed the title pins are clustered into two cluster, that are overlapping each other Pins are clustered into two cluster, that are overlapping each other Oct 7, 2017
@efremidze
Copy link
Owner

What settings are you using? Is shouldRemoveInvisibleAnnotations enabled?

@IVANKRUPSKI
Copy link
Author

No, it's not. Should that be enabled.

@efremidze
Copy link
Owner

efremidze commented Oct 9, 2017

Yes it should

@IVANKRUPSKI
Copy link
Author

Well, I played a bit with shouldRemoveInvisibleAnnotations, and couldn't solve the problem.

shouldRemoveInvisibleAnnotations when TRUE only removes pins (whether cluster or single ones) that are currently not visible on the screen. It doesn't influence pins that are currently shown on the screen.

@efremidze
Copy link
Owner

I thought u were seeing this when scrolling. Can u send me a demo?

@IVANKRUPSKI
Copy link
Author

Ok. I will try to.

@IVANKRUPSKI
Copy link
Author

IVANKRUPSKI commented Oct 10, 2017

Here it is.

https://www.dropbox.com/s/ir17dxvuhwhzq9h/test.zip?dl=0

The questions are
(1) Why sometimes two overlapping clustered pins are not consolidated into one,
(2) Why sometimes single pins, that are overlapping with clustered pin, are not consolidated into this clustered pin.

These are the screenshots from this demo, simulator iPhone 5, black - clustered pin, green-gray - single pin.
screenshot at oct 11 00-29-03
screenshot at oct 11 00-29-28
screenshot at oct 11 00-29-47

@efremidze
Copy link
Owner

Ill take a look. Make a PR if u find a solution.

@efremidze efremidze added the bug label Oct 11, 2017
@IVANKRUPSKI
Copy link
Author

Ok

@hjalmarsn
Copy link

Having the same bug of a pin being isolated in the middle of a cluster

@efremidze
Copy link
Owner

efremidze commented Oct 24, 2017

Fixed the issue in latest release 2.0.1

Add this:
manager.shouldCenterAlignClusters = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants