Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in QuadTreeNode annotations(in rect: MKMapRect) #92

Closed
4 tasks done
kylemay-gridstone opened this issue Oct 9, 2018 · 7 comments
Closed
4 tasks done

Crash in QuadTreeNode annotations(in rect: MKMapRect) #92

kylemay-gridstone opened this issue Oct 9, 2018 · 7 comments
Labels

Comments

@kylemay-gridstone
Copy link

New Issue Checklist

Issue Description

I have noticed a few times that there has been a crash in QuadTree.swift:132
The line is
for annotation in annotations where rect.contains(annotation.coordinate)
and the crash is due to index out of bounds. Presumably this is due to iterating the annotations array while it is being modified. Perhaps a copy of this array should be made inside the method to be used for the iteration. I'm not sure if this fixes it.

I cannot replicate this, however it has happened on multiple versions including the latest, 2.2.9. When this happened today the map was in memory but not visible on screen (page view controller sho8wing another page).

Environment

  • iOS Version: 12.0, have seen it on 11 also
  • Device(s): iPhone 8, iPad Mini 4
@efremidze
Copy link
Owner

efremidze commented Oct 11, 2018

Thanks for reporting. Currently fixing this issue.

@efremidze efremidze mentioned this issue Oct 11, 2018
@efremidze
Copy link
Owner

Released 2.3.0. Let me know if you still see the crash.

@efremidze efremidze added the bug label Oct 18, 2018
@petrovRV
Copy link

petrovRV commented Nov 2, 2018

@efremidze I have the same problem, I updated Cluster to the latest version (Cluster (2.4.0)).
https://drive.google.com/open?id=1JVSrB7vGc71UO7Jm93_5weLcaevItpnb

@efremidze
Copy link
Owner

efremidze commented Nov 3, 2018

I recently noticed it's still occurring. I'll fix it asap.

@antoine20001
Copy link

Same issue on Cluster (2.4.0), iPhone XR iOS 12.1

@petrovRV
Copy link

Hello. @efremidze. Do you have some news about this problem?

@efremidze
Copy link
Owner

efremidze commented Dec 6, 2018

@petrovRV @antoine20001 Sorry for the delay. I've improved thread safety in 2.4.1. Try it out.

@efremidze efremidze mentioned this issue Dec 6, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants