Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

places autocomplete field does not support translation #124

Closed
soerenmartius opened this issue Oct 21, 2014 · 6 comments
Closed

places autocomplete field does not support translation #124

soerenmartius opened this issue Oct 21, 2014 · 6 comments
Labels

Comments

@soerenmartius
Copy link

Hi, It seems like translations aren't working on the places autocomplete form field.

Moreover, when i pass attributes in the template to the form field they aren't rendered. If i go the "normal" way through a form type it works.

@egeloen
Copy link
Owner

egeloen commented Oct 21, 2014

For the attributes passed to the twig function, it is a know bug already reported in #116. For the translation, can you elaborate? What are you translating? The label? Something else?

@soerenmartius
Copy link
Author

Hi @egeloen ,
I tried it for the label and the placeholder. It failed in for both cases.

@soerenmartius
Copy link
Author

ok the label seems to work and only the placeholder fails... also inherited classes from form styles aren't loaded. I ll dig into the code and figure it out.

@egeloen
Copy link
Owner

egeloen commented Oct 21, 2014

In fact this part will be rewritten in the next major release of the bundle which will come after egeloen/ivory-google-map#95 is finalized. The major issue is the rendering is done in the buildView whereas it should be done in the template. This is why #116 is not fixable currently.

Anyway, for the issue about placeholder translation, IMO it is the expected behavior (by default no attributes are translated in the symfony2 form component) and so, it is the same here. It should be your responsibility to translate your attributes before passing them.

@soerenmartius
Copy link
Author

@egeloen this is wrong. Placeholder is translated by default in the standart edition.

@egeloen egeloen added the bug label Nov 18, 2014
@egeloen
Copy link
Owner

egeloen commented Aug 16, 2016

Your issue has been fixed in #161 but will only be part of the 3.x version of the bundle.

@egeloen egeloen closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants