Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom javascript after loading maps api async and right before Ivory generated js code #82

Closed
fnash opened this issue Jul 29, 2013 · 4 comments

Comments

@fnash
Copy link

fnash commented Jul 29, 2013

Hello,

I am loading my map asynchronously and I need to include an utility library (https://code.google.com/p/google-maps-utility-library-v3/).
So the utility js code must run right after gmaps has been loaded and just before the generated code of Ivory.
Is there a way to properly integrate any js code in the beginning of function load_ivory_google_map(); without hacking MapHelper::renderJavascripts(Map $map) ?

I think developers need a way to add custom code in this place so they can test versions and have better control of the generated js code!

It is also valid for example for the MarkerClusterer utility library which always take code from the trunk!

What do you think?

Thanks

@egeloen
Copy link
Owner

egeloen commented Jul 29, 2013

For now, there is no extension point in the code which can allow you to easily do it... So, without creating your own helper & redefine the renderJavascripts method, there is no way... :s

I'm 👍 for allowing devs to define there own js in the middle but how would you like it?

@fnash
Copy link
Author

fnash commented Jul 29, 2013

The standard way of overriding is already nice fortunately!

I will think about it!

Thanks

@egeloen
Copy link
Owner

egeloen commented Jul 30, 2013

@fnash Does the issue can be closed?

@fnash
Copy link
Author

fnash commented Jul 30, 2013

Yes!

If I have one day a better idea, I will let you know. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants