Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google places librairie with no-conflict #23

Closed
dupuchba opened this issue Jun 4, 2013 · 2 comments · Fixed by #24
Closed

Add google places librairie with no-conflict #23

dupuchba opened this issue Jun 4, 2013 · 2 comments · Fixed by #24

Comments

@dupuchba
Copy link

dupuchba commented Jun 4, 2013

Hi @egeloen ,

I was wondering if there is a way to add google places librairie without hardcoding it in here

https://github.com/egeloen/ivory-google-map/blob/master/src/Ivory/GoogleMap/Helper/MapHelper.php#L914

I need it for my websites to work, but I can't add google script alone as it raise a conflict. I need it to be declared just once

@dupuchba
Copy link
Author

dupuchba commented Jun 4, 2013

By the way the librairie is great but we should be able to call google map api's even if they are not implemented to avoid javascript dependencies. I can help if you want, just tell me where to look :)

@egeloen
Copy link
Owner

egeloen commented Jun 4, 2013

Yes I'm aware of this limitation & this is the reason of the pending PR where it partially fixes the problem. I think after merging #18, I will add a libraries property in the map allowing to explicitly load additional libraries. This way, you can easily add additional libraries. What is your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants