Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapHelper not registered for PHP template engine #27

Closed
Venzon opened this issue Apr 10, 2012 · 3 comments
Closed

MapHelper not registered for PHP template engine #27

Venzon opened this issue Apr 10, 2012 · 3 comments

Comments

@Venzon
Copy link
Contributor

Venzon commented Apr 10, 2012

Hi
I am not using twig templates and I had problem using this bundle in my project.
MapHelper service is not tagged for templating.helper and is not accessible from PHP view.
For now i created my own helper service which calls methods from \Ivory\GoogleMapBundle\Templating\Helper\MapHelper.
Is it possible to register MapHelper for PHP template engine aswell?
@egeloen
Copy link
Owner

egeloen commented Apr 10, 2012

Currently, the bundle only supports twig template engine. I have never used symfony with the PHP template engine and so, i'm absolutely not familiar with it. If you can make or start a PR, it can be usefull :). Btw, I will investigate this issue.

@Venzon
Copy link
Contributor Author

Venzon commented Apr 10, 2012

Ok, I will do PR tomorrow asap

@Venzon Venzon mentioned this issue Apr 11, 2012
Merged
@Venzon
Copy link
Contributor Author

Venzon commented Apr 11, 2012

PR is ready, please check it out

@egeloen egeloen closed this as completed Apr 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Venzon @egeloen