Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS version (or supported methods) #64

Open
BrAwnyTime opened this issue Nov 20, 2019 · 1 comment
Open

NodeJS version (or supported methods) #64

BrAwnyTime opened this issue Nov 20, 2019 · 1 comment

Comments

@BrAwnyTime
Copy link

I attempted to use your library server-side in a NestJS application, but due to ZipJS throwing an error on blob is not supported by this platform specifically at jszip/lib/utils.js:352:15. It does look like this is possible.

I believe NodeJS would be support with two changes:

  • if the config object was allowed to provide the type that ZipJS would use instead of hard coding blob
  • if the Promise of the zip was returned from a generateXLSX(config) and the .then((blob) => Filesaver...) could be supplied on the default export which would just call the generateXLSX` function.

i'd be happy to contribute to the library if this is an acceptable solution/direction.

@egeriis
Copy link
Owner

egeriis commented Nov 22, 2019

@BrAwnyTime Feel free to submit a PR. I've got one strict rule, that you'll see repeated through many PRs: this lib is sensitive to bundle size increases, as it's sole purpose is to create valid xlsx output as lightweight as possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants