Chinese language support

[pirishd]

There does not seem to be Chinese language support in the library contrary to what the documentation says: https://github.com/eggheadgames/Siren#localization.

Am I right? Is the support of this language planned?

[mikemee]

Hi @pirishd , we should have all the languages that the iOS Siren supports, but perhaps we missed some, or they were added between when we created the code and copied and modified the documentation.

If you can tell me which ones from here: https://github.com/ArtSabintsev/Siren/tree/master/Sources/Siren.bundle that you need that are missing from our list here https://github.com/eggheadgames/Siren/tree/develop/library/src/main/res, we can add them. If you know the equivalent Android language code(s) too, that will speed things up.

Or, of course, feel free to give us a PR 👍

Thanks!

[pirishd]

Hi @mikemee, I created a PR to add the support of the Chinese language (based on the translations found in https://github.com/ArtSabintsev/Siren/blob/master/Sources/Siren.bundle/zh-Hans.lproj/SirenLocalizable.strings).

Would you please review that?

[mikemee]

@pirishd Thanks! Let's continue in the PR, where I have a question.

[mikemee]

@pirishd Many thanks for the issue and PR. This was fixed in release 1.4.8.