Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Title "Update Available" #37

Closed
janicelco opened this issue Dec 4, 2017 · 7 comments
Closed

Dialog Title "Update Available" #37

janicelco opened this issue Dec 4, 2017 · 7 comments
Assignees

Comments

@janicelco
Copy link

Dialog title is only showing on Android 5 device.
I have run the code on:
Samsung Note 3, Android 5.0.1 (Shows title)
Nexus 7, Android 6.0.1 (No title)
Samsung S6, Android 7.0.1 (No title)

How to i ensure that the title is showing on all devices?

@mikemee
Copy link
Collaborator

mikemee commented Dec 4, 2017

Do you happen to have screenshots? Thanks!

@janicelco
Copy link
Author

Android 5:
android_5

Android 7:
android_7

We are using Japanese text not by localisation as our client wants a different text. I have override the strings.

@mikemee
Copy link
Collaborator

mikemee commented Dec 5, 2017

Thanks, we'll take a look. I remember some similar weirdness with Android dialogs in a different scenario.

@Apisov @AlexDibrivnyy any ideas?

@janicelco
Copy link
Author

@mikemee,

Maybe you need to use AlertDialog.Builder?
AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
builder.setTitle("Update Available")...

I've been following https://developer.android.com/guide/topics/ui/dialogs.html while building my application.

@mikemee
Copy link
Collaborator

mikemee commented Dec 5, 2017

@janicelco you could always import the source code directly from this library and try it 👍

@AlexDibrivnyy AlexDibrivnyy self-assigned this Dec 7, 2017
@mikemee mikemee closed this as completed in 86ee18a Dec 8, 2017
@mikemee
Copy link
Collaborator

mikemee commented Dec 8, 2017

@janicelco This should be fixed for release 1.5.2. Please double check and let us know. Thanks!

@janicelco
Copy link
Author

@mikemee Thanks! Checked it for Android 7.0. Its now showing. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants