Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Get app version from Google Play Store rather than hosting a json #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robertofrontado
Copy link

@robertofrontado robertofrontado commented Sep 24, 2018

I really like this library 馃憤 Very nice work!

But I realized that it didn't work the same way as the iOS version

So I added this is the new method:

public void checkVersion(Activity activity, SirenVersionCheckType versionCheckType) {
...
}

So there is no need to pass the url of the json 馃檶

Note: I added this as an extra functionality, so if you still want to keep the updates alerts via json you can 馃憤

@robertofrontado
Copy link
Author

@eggheadgames I think you will need to handle that error in CircleCI

* What went wrong:
A problem occurred configuring project ':library'.
> Failed to install the following Android SDK packages as some licences have not been accepted.
     build-tools;27.0.3 Android SDK Build-Tools 27.0.3

@mikemee
Copy link
Collaborator

mikemee commented Sep 24, 2018

Thanks @robertofrontado ! I'm swamped at the moment, but I've made a note to look at this deeper in a week or so (when some iOS 12 urgent stuff has hopefully passed!).

I did look at doing it this way originally, but my research suggested it was pretty dicey to do it that way, between various versions of the Play store, etc. etc. However, I'll take a look at the PR, and providing it as an option might make sense for those who want to try it.

Thanks for the other cleanup too!

@robertofrontado
Copy link
Author

@mikemee Thank you!

Indeed, I thought this as a complement of the current functionality, which is already working nicely 馃憤 so there was no need to change that.

If you have any comments please let me know 馃憢

Hope it can get merged soon!

@StainlessStlRat
Copy link

Any reason this was never pushed? I'd like to use the library, but don't want to add another step I have to remember every time an update releases.

@robertofrontado
Copy link
Author

@StainlessStlRat No idea, but you can use my fork for now until this gets merged

implementation 'com.github.robertofrontado:Siren:1.7.0' // This is a fork of https://github.com/eggheadgames/Siren, because that one didn't fetch the version number from google play yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants