Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: check and show "You have the latest" dialog #6

Closed
xstar97 opened this issue May 10, 2016 · 3 comments
Closed

request: check and show "You have the latest" dialog #6

xstar97 opened this issue May 10, 2016 · 3 comments

Comments

@xstar97
Copy link

xstar97 commented May 10, 2016

its me again...annoying...right?
So I was wondering since I am able to check if my app has an update & if there is show an update dialog...but if there isn't an update then a no update dialog pops up saying "you have the latest update....blah blah"
it will be cool if this was an extra option...
could you also add this in the next update?

@mikemee
Copy link
Collaborator

mikemee commented May 10, 2016

Hi. Not annoying at all. We appreciate the interest!

I'm not inclined to add this feature at the moment, as one of the goals is to keep compatibility with the iOS library of the same name.

That said, I think you could emulate this behaviour yourself by adding a listener. Though, as I look at it, it might be tricky to detect the "no update" case.

I'll take another look at siren for iOS to be sure, but my inclination is to leave it for now.

(Btw, almost done with a fix for the issue you raised yesterday, thanks!)

@xstar97
Copy link
Author

xstar97 commented May 10, 2016

thats awesome cant wait for the new update!

@mikemee mikemee changed the title feature request request: check and show "You have the latest" dialog May 11, 2016
@mikemee
Copy link
Collaborator

mikemee commented May 11, 2016

I've checked, and the iOS version of Siren doesn't have this, so we're going to not add it for the moment. However, we'll definitely keep it in mind for the future.

@mikemee mikemee closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants