fix: should not set sameSite and CHIPS when secure = false #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 234 237 +3
Branches 61 61
=========================================
+ Hits 234 237 +3 ☔ View full report in Codecov by Sentry. |
fengmk2
commented
Dec 28, 2023
fengmk2
commented
Dec 28, 2023
| } | ||
| } | ||
| if (opts.partitioned) { | ||
| if (!this.secure || (userAgent && !this.isPartitionedCompatible(userAgent))) { | ||
| // allow to set partitioned: secure=true and sameSite=none and chrome >= 118 |
There was a problem hiding this comment.
需要满足3个条件才能设置 partitioned
fengmk2
pushed a commit
that referenced
this pull request
Dec 28, 2023
[skip ci] ## [2.8.3](v2.8.2...v2.8.3) (2023-12-28) ### Bug Fixes * should not set sameSite and CHIPS when secure = false ([#45](#45)) ([33395bf](33395bf))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.