fix: every it should has self ctx #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 82.88% // Head: 82.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 82.88% 82.93% +0.05%
==========================================
Files 27 27
Lines 2465 2514 +49
Branches 409 423 +14
==========================================
+ Hits 2043 2085 +42
- Misses 422 429 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
reviewed
Jan 18, 2023
| } | ||
| return next(i + 1); | ||
| } | ||
| next(0).catch(e => { |
There was a problem hiding this comment.
差一点就要 require('async') 了。
fengmk2
reviewed
Jan 18, 2023
| if (!test) { | ||
| return done(); | ||
| } | ||
| suite.tests = [ test ]; |
There was a problem hiding this comment.
也是通过 next 这样的方式来顺序执行的。
There was a problem hiding this comment.
fengmk2
pushed a commit
that referenced
this pull request
Jan 18, 2023
[skip ci] ## [5.9.3](v5.9.2...v5.9.3) (2023-01-18) ### Bug Fixes * every it should has self ctx ([#150](#150)) ([bf33c1c](bf33c1c))
|
🎉 This PR is included in version 5.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change