Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egg-loader #11

Closed
gxcsoccer opened this issue Jul 15, 2016 · 13 comments
Closed

egg-loader #11

gxcsoccer opened this issue Jul 15, 2016 · 13 comments
Assignees
Milestone

Comments

@gxcsoccer
Copy link
Contributor

关于 loader 有几个问题,需要先确定下

  • 运行环境及其名称,是否还是这几个 prod, test, default, local, unittest
  • 运行环境如何确定,除了 process.env.NODE_ENV
  • 是否还需要支持 framework 封装这个功能?

先想到这些,后面有再补充

@gxcsoccer gxcsoccer added this to the v1.x milestone Jul 15, 2016
@atian25
Copy link
Member

atian25 commented Jul 15, 2016

  • loader 的需要支持 framework 更容易扩展的, 见 egg-core #10 (comment)
  • testunittest 其实对初学者有点混淆的, 外面大部分时候把 test 当为单元测试.

@popomore
Copy link
Member

loader 先迁移脱敏,改造放到后面吧

@fengmk2
Copy link
Member

fengmk2 commented Jul 15, 2016

env 没变。 @atian25 这个不需要变化,没 test 的就只用 unittest 就好,文档说明白就好。

@popomore
Copy link
Member

环境还是原来那个表格吧

@fengmk2
Copy link
Member

fengmk2 commented Jul 15, 2016

@popomore loader 是支持多层 egg 叠加的吧?

@gxcsoccer
Copy link
Contributor Author

脱敏是把公司相关的信息拿掉? 中文注释呢?

@fengmk2
Copy link
Member

fengmk2 commented Jul 15, 2016

@gxcsoccer 中文注释等 1.0.0 正式版本的时候改成英文。现在先保证 0.0.1 能跑起来。

@gxcsoccer
Copy link
Contributor Author

好的

@gxcsoccer
Copy link
Contributor Author

@popomore proxy 也先不动了?

那我只要把 antx 拿掉就好了

@fengmk2
Copy link
Member

fengmk2 commented Jul 15, 2016

@gxcsoccer loadAntx 的改动 diff 得先给我看看,loadConfig 还需要依赖一些基本信息。

@fengmk2
Copy link
Member

fengmk2 commented Jul 15, 2016

loadProxy 是一种约定,我觉得留着没问题的。

@gxcsoccer
Copy link
Contributor Author

👌

@popomore
Copy link
Member

@fengmk2 支持多层的

gxcsoccer pushed a commit to eggjs/egg-core that referenced this issue Jul 15, 2016
elrrrrrrr pushed a commit to elrrrrrrr/egg that referenced this issue Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants