Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ctx.getLogger(name) #36

Closed
fengmk2 opened this issue Aug 5, 2016 · 7 comments · Fixed by #136
Closed

add ctx.getLogger(name) #36

fengmk2 opened this issue Aug 5, 2016 · 7 comments · Fixed by #136
Assignees
Milestone

Comments

@fengmk2
Copy link
Member

fengmk2 commented Aug 5, 2016

https://github.com/eggjs/egg/blob/master/lib/core/app/extend/context.js#L207

方便获取自定义 logger,并且自动填充 ctx 信息,就如 ctx.logger 一样。

@fengmk2 fengmk2 added this to the v1.x milestone Aug 5, 2016
@fengmk2 fengmk2 self-assigned this Aug 5, 2016
@popomore
Copy link
Member

popomore commented Aug 5, 2016

那默认都加上?ctx.loggers 对象?

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 5, 2016

ctx.loggers 对象实现太麻烦,还是 ctx.getLogger(name) 比较简单。

@popomore
Copy link
Member

popomore commented Aug 5, 2016

动态创建?如果非动态的和 ctx.loggers 是一样的,和 app.loggers 实现一致。

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 5, 2016

后面app的也统一推荐使用getLogger接口吧

Sent from my iPhone

On Aug 5, 2016, at 7:25 PM, Haoliang Gao notifications@github.com wrote:

动态创建?如果非动态的和 ctx.loggers 是一样的,和 app.loggers 实现一致。


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

@popomore
Copy link
Member

popomore commented Aug 5, 2016

那要动态创建加缓存了,其实 loggers 就是用 map,只是提前初始化了。

@popomore popomore modified the milestone: v1.x Aug 13, 2016
@popomore popomore assigned popomore and unassigned fengmk2 Aug 17, 2016
@popomore
Copy link
Member

这个做了没?

@fengmk2
Copy link
Member Author

fengmk2 commented Oct 19, 2016

没做。

popomore added a commit that referenced this issue Nov 1, 2016
it can be override with custom logical

Closes #36
popomore added a commit that referenced this issue Nov 1, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 1, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 1, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 1, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 1, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 2, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 2, 2016
it can be override with custom function

Closes #36
popomore added a commit that referenced this issue Nov 2, 2016
it can be override with custom function

Closes #36
fengmk2 pushed a commit that referenced this issue Nov 2, 2016
it can be override with custom function

Closes #36
popomore pushed a commit that referenced this issue Apr 12, 2019
Revert "feat: switch httpclient to httpclient2 for retry feature (#36… (#3622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants