Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ssrf declaration #4687

Merged
merged 3 commits into from
Jan 2, 2023
Merged

fix: add ssrf declaration #4687

merged 3 commits into from
Jan 2, 2023

Conversation

duenyang
Copy link
Contributor

@duenyang duenyang commented Jun 1, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Base: 99.85% // Head: 99.85% // No change to project coverage 👍

Coverage data is based on head (2856ebf) compared to base (7b8edbf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4687   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          35       35           
  Lines        3483     3483           
  Branches      510      510           
=======================================
  Hits         3478     3478           
  Misses          5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Wai-Dung Wai-Dung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duenyang: Thanks for your 1st contribution!

@Wai-Dung Wai-Dung requested a review from whxaxes June 30, 2021 03:08
@atian25 atian25 requested a review from hubcarl June 30, 2021 05:57
Copy link
Contributor

@Wai-Dung Wai-Dung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whxaxes & @hubcarl :This is right with me and I approved it. But where to write the unit test for it? Can this be merged first or……?

index.d.ts Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jan 2, 2023

@fengmk2 is attempting to deploy a commit to a Personal Account owned by @eggjs on Vercel.

@eggjs first needs to authorize it.

@fengmk2 fengmk2 merged commit b1414f2 into eggjs:master Jan 2, 2023
atian25 pushed a commit that referenced this pull request Jan 2, 2023
[skip ci]

## [3.11.0](v3.10.0...v3.11.0) (2023-01-02)

### Features

* add ssrf declaration ([#4687](#4687)) ([b1414f2](b1414f2))
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

iblogc pushed a commit to iblogc/egg that referenced this pull request Jan 9, 2023
Co-authored-by: deydu <deydu@tencent.com>
Co-authored-by: fengmk2 <fengmk2@gmail.com>
iblogc pushed a commit to iblogc/egg that referenced this pull request Jan 9, 2023
[skip ci]

## [3.11.0](eggjs/egg@v3.10.0...v3.11.0) (2023-01-02)

### Features

* add ssrf declaration ([eggjs#4687](eggjs#4687)) ([b1414f2](eggjs@b1414f2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants