Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egg 文件命名规范 #4

Closed
dead-horse opened this issue Jun 19, 2016 · 6 comments · Fixed by eggjs/egg-bin#3
Closed

egg 文件命名规范 #4

dead-horse opened this issue Jun 19, 2016 · 6 comments · Fixed by eggjs/egg-bin#3
Assignees
@fengmk2
Labels
type: question
Milestone
1.0.0

Comments

@dead-horse
Copy link
Member

我们是大写分隔，如果是类就首字母大写还是下划线分隔？

https://github.com/eggjs/egg-bin/blob/master/lib/Command.js
@dead-horse dead-horse added this to the v1.0 milestone Jun 19, 2016
@fengmk2
Copy link
Member

fengmk2 commented Jun 20, 2016

这种纯类的定义文件，还是保持跟类名一直吧，也符合 react 的写法，要不然同时写 react 又写 node，会分裂。

@popomore
Copy link
Member

我习惯下划线，文件名不和代码应该没有相关性。

@atian25
Copy link
Member

atian25 commented Jun 21, 2016 •
edited

类的话, 我这边是保持类名.

其实类名和下划线都行, 偏向前者. 如果是驼峰的, 就烧死

@dead-horse
Copy link
Member Author

因为类名可能就是大写开头的驼峰了，如果还用下划线做分隔符的话就有混用的感觉。。

@gxcsoccer
Copy link
Contributor

下划线 +1

@fengmk2
Copy link
Member

fengmk2 commented Jul 8, 2016

那我改成小写+下划线

@fengmk2 fengmk2 mentioned this issue Jul 8, 2016
Merged
@fengmk2 fengmk2 self-assigned this Jul 8, 2016
fengmk2 added a commit to eggjs/egg-bin that referenced this issue Jul 9, 2016
@fengmk2
refactor: rename DevCommand.js to dev_command.js
11536f1 
closes eggjs/egg#4
dead-horse pushed a commit to eggjs/egg-bin that referenced this issue Jul 9, 2016
@fengmk2 @dead-horse
refactor: rename DevCommand.js to dev_command.js (#3)
46c1406 
* chore: add security check badge

* refactor: rename DevCommand.js to dev_command.js

closes eggjs/egg#4

* docs: English first readme

* test: use coffee@3 to run test

* test: improve iron-node install
@ZQun ZQun mentioned this issue Jan 9, 2019
Closed
elrrrrrrr pushed a commit to elrrrrrrr/egg that referenced this issue Feb 21, 2023
@atian25 @fengmk2
feat: add hackernews showcase (eggjs#4)
af487f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengmk2 fengmk2

Labels
type: question
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

refactor: rename DevCommand.js to dev_command.js eggjs/egg-bin
5 participants
@fengmk2 @atian25 @popomore @dead-horse @gxcsoccer