Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): app.router.url params should be optional #5132

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 19, 2023

add missing pathFor and methods defines

@fengmk2 fengmk2 marked this pull request as draft January 19, 2023 13:30
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 99.85% // Head: 99.85% // No change to project coverage 👍

Coverage data is based on head (d71fedb) compared to base (483bf1d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5132   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          35       35           
  Lines        3488     3488           
  Branches      512      512           
=======================================
  Hits         3483     3483           
  Misses          5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

add missing pathFor and methods defines
@fengmk2 fengmk2 marked this pull request as ready for review January 19, 2023 13:41
@fengmk2 fengmk2 merged commit dda6bb3 into master Jan 20, 2023
@fengmk2 fengmk2 deleted the app-router-url branch January 20, 2023 10:55
fengmk2 pushed a commit that referenced this pull request Jan 20, 2023
[skip ci]

## [3.14.2](v3.14.1...v3.14.2) (2023-01-20)

### Bug Fixes

* **types:** app.router.url params should be optional ([#5132](#5132)) ([dda6bb3](dda6bb3))
@github-actions
Copy link

🎉 This PR is included in version 3.14.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

iblogc pushed a commit to iblogc/egg that referenced this pull request Mar 13, 2023
iblogc pushed a commit to iblogc/egg that referenced this pull request Mar 13, 2023
[skip ci]

## [3.14.2](eggjs/egg@v3.14.1...v3.14.2) (2023-01-20)

### Bug Fixes

* **types:** app.router.url params should be optional ([eggjs#5132](eggjs#5132)) ([dda6bb3](eggjs@dda6bb3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant